chore: enable Rust 2024 edition lints #2728
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2728 +/- ##
=====================================
Coverage 79.4% 79.4%
=====================================
Files 123 123
Lines 22781 22781
=====================================
Hits 18106 18106
Misses 4675 4675 ☔ View full report in Codecov by Sentry. |
scottgerring
left a comment
scottgerring
left a comment
There was a problem hiding this comment.
Cool! I reckon we should deal with the lints at the same time, but other than that I think this is a great idea.
|
|
||
| [workspace.lints.rust] | ||
| rust_2024_compatibility = { level = "warn", priority = -1 } | ||
| # No need to enable those, because it either not needed or results in ugly syntax |
There was a problem hiding this comment.
IMHO idiomatic rust syntax is what the default rustc lint set enforces; I think we should have strong reasons to opt out of these, and it would be nice to make the linter happy at the same time as we turn on the linting support.
Appreciate though that this will add a bunch of noise to the PR beyond the core 'turn on 2024 linting' flag. @cijothomas what do you think?
if_let_rescope - cargo clippy --fix seems to clean up most of these.
tail_expr_drop_order - this one can't be autofixed, but seems fairly straightforward:
However, the most probable fix is to hoist Droppy into its own local variable binding.
Co-authored-by: Lalit Kumar Bhasin <[email protected]> Co-authored-by: Cijo Thomas <[email protected]>
Co-authored-by: Lalit Kumar Bhasin <[email protected]> Co-authored-by: Cijo Thomas <[email protected]>
5 participants
Changes
Merge requirement checklist
CHANGELOG.mdfiles updated for non-trivial, user-facing changes